Skip to content

Conversation

busunkim96
Copy link
Contributor

Increase protobuf version to 3.12.0 for _internal_create_key.

See protocolbuffers/protobuf@b99994d for the commit where this was added.

Fixes #48 🦕

Increase protobuf version to 3.12.0 for `_internal_create_key`. Closes #48
@busunkim96 busunkim96 requested review from crwilcox and plamut June 15, 2020 16:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2020
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

With protobuf==3.12.0, the following import does not result in an error anymore, unlike in some older protobuf versions:

from google.cloud.pubsub_v1.types import PushConfig

@busunkim96 busunkim96 merged commit 1ba6095 into master Jun 16, 2020
@tseaver tseaver deleted the busunkim96-patch-1 branch December 8, 2020 18:12
This was referenced May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the pubsub client breaks because it needs a newer version of protobuf
3 participants